stream: cleanup and fix Readable.wrap #34204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
stream
ronag
added
the
semver-major
Member
Author
|
@nodejs/streams @mafintosh |
ronag
commented
Jul 4, 2020
lib/_stream_readable.js
Outdated
Member
Author
There was a problem hiding this comment.
Readable should already handle all of the above. Not sure why this was put here. Legacy?
ronag
force-pushed
the
readable-wrap
branch
7 times, most recently
from
8c12016 to
39ef8e3
Compare
Cleans up Readable.wrap and also ensures destroy is called for certain events.
ronag
commented
Jul 4, 2020
| stream.on('resume', () => { | ||
| // TODO(ronag): this.resume()? | ||
| this.emit('resume'); | ||
| }); |
Member
Author
There was a problem hiding this comment.
I'm a little unsure what to do exactly when the wrapped stream emits pause and resume. I don't think it's relevant?
addaleax
approved these changes
Jul 4, 2020
ronag
added
the
author ready
Collaborator
lpinca
reviewed
Jul 6, 2020
lpinca
approved these changes
Jul 7, 2020
jasnell
approved these changes
Jul 7, 2020
Member
|
LGTM but would really like @mcollina to sign off before it lands |
Collaborator
Member
Author
ronag
added a commit
that referenced
this pull request
Jul 11, 2020
Cleans up Readable.wrap and also ensures destroy is called for certain events. PR-URL: #34204 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: James M Snell <[email protected]>
Member
Author
|
Landed in 4e3f6f3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up Readable.wrap and also ensures destroy is called for certain events.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes